Implement baml language server code completions #2581
Conversation
Co-authored-by: aaron <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aaronvg
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
aaronvg
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
aaronvg
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| get_symbol_before_position(&doc.contents, &prev_pos) | ||
| } else { | ||
| String::new() | ||
| }; |
There was a problem hiding this comment.
Bug: Block Attribute Detection Logic Error
The logic for detecting @@ block attributes is flawed. When prev is identified as @, the subsequent check for a second @ uses get_symbol_before_position on a position one character back from the cursor. This effectively checks two positions back from the cursor, which may incorrectly identify or miss the @@ pattern.
|
🌿 Preview your docs: https://boundary-preview-d74e1fd7-4b58-4240-8d97-cce56a7bb652.docs.buildwithfern.com |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
2 participants
Add context-aware code completions to the BAML language server for attributes, prompt helpers, keywords, and IR symbols.
Slack Thread
Note
Adds LSP completion logic for attributes, prompt helpers, keywords, and IR-derived symbols, plus a basic completion test and resilient logging init.
engine/language_server/src/server/api/requests/completion.rs.get_word_at_positionandget_symbol_before_position(attributes@/@@,_.role(,ctx./ctx.client., top-level).@alias,@stream.*,@@dynamic, etc.), prompt helpers (_.role("system"|"user"|"assistant"),ctx.output_format,ctx.client.*), top-level keywords (function,class,enum,client,generator,retry_policy,template_string,type), and IR symbols (functions/classes/enums/type aliases) via runtime.CompletionResponse::ListwithCompletionItemKindand minimal details; add helper builders.test_basic_attribute_completioninengine/language_server/src/tests.rsvalidating@aliassuggestion.engine/language_server/src/logging.rs, avoid panic if global subscriber already set; print warning and continue.docs/lsp-completions-design.mdoutlining goals, approach, examples, and testing.Written by Cursor Bugbot for commit 6672932. This will update automatically on new commits. Configure here.