Skip to content

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented May 18, 2022

After trying to understand this method, I'm sorry to report but my 🧠 brain hurt.

This PR makes it easy to understand and maintain. Please see decreasing Complexity below.

@szepeviktor szepeviktor marked this pull request as draft May 18, 2022 01:34
@codecov-commenter
Copy link

Codecov Report

Merging #28 (6e8332e) into master (15564dc) will decrease coverage by 0.63%.
The diff coverage is 81.25%.

@@             Coverage Diff              @@
##             master      #28      +/-   ##
============================================
- Coverage     78.13%   77.50%   -0.64%     
+ Complexity      230      227       -3     
============================================
  Files            30       30              
  Lines           439      440       +1     
============================================
- Hits            343      341       -2     
- Misses           96       99       +3     
Impacted Files Coverage Δ
src/QueryTemplate.php 90.69% <81.25%> (-6.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15564dc...6e8332e. Read the comment docs.

@szepeviktor szepeviktor marked this pull request as ready for review May 18, 2022 01:52
@szepeviktor
Copy link
Contributor Author

@gmazzap friendly ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants