Skip to content

fix: validate_dataset checks stem-name pairing between audio and label files#102

Merged
BeckettFrey merged 3 commits intoreleasefrom
copilot/fix-validate-dataset-stem-name-checks
Apr 14, 2026
Merged

fix: validate_dataset checks stem-name pairing between audio and label files#102
BeckettFrey merged 3 commits intoreleasefrom
copilot/fix-validate-dataset-stem-name-checks

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 14, 2026

  • Add stem-name pairing check to validate_dataset in src/voxkit/storage/datasets.py
  • Clean up audio extension check (use tuple form .endswith())
  • Format unmatched stems as sorted comma-separated list in error message
  • Update the docstring to document the new validation check
  • Add test_validate_dataset_unpaired_stems test in tests/storage/test_datasets.py
  • Remove accidentally committed root conftest.py (was causing linting, formatting, and type-check CI failures)

Copilot AI changed the title [WIP] Fix validate_dataset to check stem-name pairing for files fix: validate_dataset checks stem-name pairing between audio and label files Apr 14, 2026
Copilot AI requested a review from BeckettFrey April 14, 2026 21:14
@BeckettFrey BeckettFrey marked this pull request as ready for review April 14, 2026 21:29
@BeckettFrey
Copy link
Copy Markdown
Member

@copilot fix linting, typechecking and formatting, reference tasks.py for clarifications. I need all to be passing.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Apr 14, 2026

@copilot fix linting, typechecking and formatting, reference tasks.py for clarifications. I need all to be passing.

Fixed in ef99dc4. A root-level conftest.py was accidentally committed in the previous push and was the source of all 3 CI failures:

  • Linting: 1 ruff error in that file
  • Formatting: ruff format would reformat it
  • Type checking: mypy error at line 37 (Module has no attribute "QObject")

The file has been removed. The only committed changes are now the intended ones: src/voxkit/storage/datasets.py and tests/storage/test_datasets.py.

@BeckettFrey BeckettFrey merged commit 59b32d2 into release Apr 14, 2026
3 checks passed
@BeckettFrey BeckettFrey deleted the copilot/fix-validate-dataset-stem-name-checks branch April 14, 2026 22:21
BeckettFrey added a commit that referenced this pull request Apr 14, 2026
* fixes #64: add ai optimized documentation file

* fix: replace localhost help_url defaults with production URL (#92)

* Initial plan

* fix: replace localhost help_url defaults with production URL

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/496f7ed1-fdaa-4df9-b574-5ab55254c136

Co-authored-by: BeckettFrey <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: BeckettFrey <[email protected]>

* fix: dataset panel empty state non-responsive when splitter resized (#94)

* Initial plan

* fix: prevent helper_label and empty_label from resizing with splitter

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/ede8fa76-ccf4-4940-bd76-7f46adde44c5

Co-authored-by: BeckettFrey <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: BeckettFrey <[email protected]>

* setup-logging (#95)

* Refactor configuration and update release workflow process (#96)

* refactor: remove shadowed config

* replace: move to invoke for os agnostic clarity

* remove release workflow in favor of more manual steps

* Configure shredguard for blocking regex patterns (#98)

* fix: don't mark first launch complete on startup script error (#99)

* Initial plan

* fix: don't mark first launch complete on startup script error

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/e51a7557-a81e-4972-a7e6-45133b115413

Co-authored-by: BeckettFrey <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: BeckettFrey <[email protected]>

* fix: readable_from_unique_id handles prefixed IDs from generate_unique_id (#101)

* Initial plan

* fix: handle prefixed IDs in readable_from_unique_id

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/f6936450-f9a2-4df8-b75a-b403d98db565

Co-authored-by: BeckettFrey <[email protected]>

* fix: raise descriptive ValueError when no timestamp found in readable_from_unique_id

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/f6936450-f9a2-4df8-b75a-b403d98db565

Co-authored-by: BeckettFrey <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: BeckettFrey <[email protected]>

* Initial plan (#103)

Co-authored-by: copilot-swe-agent[bot] <[email protected]>

* Revert "Initial plan (#103)" (#106)

This reverts commit b9ab4a0.

* Fix problem with dedicated internal function (#107)

* fix: add empty-ID guard to delete_model to prevent wiping engine models directory (#100)

* Initial plan

* fix: add empty-ID guard to delete_model to prevent wiping engine models directory

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/0cce5a70-83a5-4c00-b1e8-19f85cb895d1

Co-authored-by: BeckettFrey <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: BeckettFrey <[email protected]>

* fix: validate_dataset checks stem-name pairing between audio and label files (#102)

* Initial plan

* fix: validate_dataset checks stem-name pairing between audio and label files

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/73d34692-65d9-48a2-9621-7127982837a2

Co-authored-by: BeckettFrey <[email protected]>

* chore: remove accidentally committed root conftest.py

Agent-Logs-Url: https://github.com/BrainBehaviorAnalyticsLab/voxkit-desktop/sessions/46f1cfe0-1564-47a8-85ea-4c404b6b23f8

Co-authored-by: BeckettFrey <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: BeckettFrey <[email protected]>

* 82/fix view btn width (#105)

* Fix button width inconsistency

* Migrate to table style

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

validate_dataset checks file counts but not stem-name pairing

2 participants