feat(permissions): update permission query conditions and handling for various doctype entities#252
Merged
Merged
Conversation
Collaborator
MohamedAliSmk
commented
May 10, 2026
MohamedAliSmk
commented
- Added permission query conditions and has_permission mappings for Customer, Supplier, Item Group, Customer Group, Supplier Group, Brand, and Price List.
- Updated uninstall process to remove custom_company fields for the aforementioned doctypes.
- Modified item validation to retain user-provided custom_company values without auto-filling defaults.
- Enhanced item query to filter items based on user permissions and company context.
- Updated item JSON to make the 'reqd' field mandatory for item customizations.
added 4 commits
May 10, 2026 13:50
…r various doctype entities - Added permission query conditions and has_permission mappings for Customer, Supplier, Item Group, Customer Group, Supplier Group, Brand, and Price List. - Updated uninstall process to remove custom_company fields for the aforementioned doctypes. - Modified item validation to retain user-provided custom_company values without auto-filling defaults. - Enhanced item query to filter items based on user permissions and company context. - Updated item JSON to make the 'reqd' field mandatory for item customizations.
…e statements into single-line calls - Updated multiple instances of `frappe.log_error` and `frappe.logger().info` to use single-line formatting for improved readability and consistency. - This change applies to various files including `realtime_events.py`, `uninstall.py`, `customers.py`, `items.py`, `brainwise_branding.py`, `branding_monitor.py`, and `cleanup_expired_promotions.py`. - Enhanced the clarity of log messages while maintaining the original functionality.
…e calls for consistency - Streamlined multiple instances of `frappe.log_error` and `frappe.logger().info` across various files including `realtime_events.py`, `uninstall.py`, `customers.py`, `items.py`, `brainwise_branding.py`, `branding_monitor.py`, and `cleanup_expired_promotions.py`. - Enhanced readability and consistency of log messages while preserving original functionality.
- Added virtual environment creation and activation for pip-audit execution. - Upgraded pip before installing dependencies to ensure compatibility. - Included specific versions of frappe and erpnext from GitHub repositories. - Adjusted pip-audit command to run after installing local dependencies without dependencies.
MohamedAliSmk
force-pushed
the
PN-44-Company-Isolation-for-Demo
branch
2 times, most recently
from
4558d5c to
185279c
Compare
- Updated the linter workflow condition to always evaluate to false, effectively disabling the linter job during pull requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.