Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wxDAI endpoint #32

Merged
merged 3 commits into from
Feb 4, 2025
Merged

wxDAI endpoint #32

merged 3 commits into from
Feb 4, 2025

Conversation

RonTuretzky
Copy link
Contributor

No description provided.

hudsonhrh
hudsonhrh requested changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@hudsonhrh hudsonhrh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should call _mint(receiver, amount), val does not exist in this function

also should probably use custom error instead of require revert for consistency.

EDIT: ended up removing require completely because safeTransferFrom reverts already if fails

bagelface
bagelface requested changes Feb 3, 2025
View reviewed changes
Copy link

@bagelface bagelface left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo we shouldn't be adding anything like this without also adding tests for it

@hudsonhrh hudsonhrh requested a review from bagelface February 4, 2025 00:32
@RonTuretzky
Copy link
Contributor Author

@bagelface we good?

bagelface
bagelface approved these changes Feb 4, 2025
View reviewed changes
Copy link

@bagelface bagelface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RonTuretzky RonTuretzky merged commit 974ed29 into main Feb 4, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudsonhrh hudsonhrh hudsonhrh approved these changes

@bagelface bagelface bagelface approved these changes

@rubydusa rubydusa rubydusa approved these changes

@kassandraoftroy kassandraoftroy Awaiting requested review from kassandraoftroy

@daopunk daopunk Awaiting requested review from daopunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RonTuretzky @hudsonhrh @bagelface @rubydusa