Add firmware log event support and update trace payloads#24
Open
usrflo wants to merge 5 commits into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
…fixed notifyTxComplete Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI added a firmware log event so DEBUG output is merged into the JSON log output.
This way I can see output like the following that I didn't expect or wasn't aware of so far.
The trace output would have revealed this as well but filtering the JSON output can be done better.
1 line needs to be patched in Meshcore.h, see the modification in the patch file.
I worked on Linux but should be re-checked on Windows IMHO.