fixed JSON parsing for Info model (int to float32)#6
Open
Dadard29 wants to merge 1 commit intoBrianAllred:masterfrom
Open
fixed JSON parsing for Info model (int to float32)#6Dadard29 wants to merge 1 commit intoBrianAllred:masterfrom
Dadard29 wants to merge 1 commit intoBrianAllred:masterfrom
Conversation
|
+1 |
1 similar comment
|
+1 |
izackwu
approved these changes
Oct 13, 2021
izackwu
left a comment
izackwu
left a comment
There was a problem hiding this comment.
exactly what I needed to make this library work
Author
|
Since the bug has been active for a while... I guess you can use my fork (which includes the fix): https://github.com/Dadard29/goydl. |
|
Yeah, I've been using your fork to get around this, congrats on your first PR. I hope to find a bug in a not-so-active repository so I can make a PR too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
The JSON parsing of the Info model was failing due to a cast error.
It's my first PR in Open Source, please let me know if its the right way to submit changes.
Regards