Rewrote the script#5
Open
Pyth3rEx wants to merge 29 commits into
Open
Conversation
Added proper naming convention for 'reg:' items
Renamed GetVin and GetVINVEH to EnsureVehicleVIN & HandleVehicleVIN respectively because fuck understanding what's going on right? (ye I know I'm mean but it's 2 am and I'm low on coffe. programers will understand, listening to hardstyle btw :P )
Removed useless checks redid everything
switching zone sytem to proper qb-target to avoid wonky functions. reverse compatibility for other systems will need to be added
fuck global functions
messing with functions and removing garbage
forgot that config was a thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote the script logic and control flow for clarity, simplicity, performance optimization and fix a few exploits.
see commits for full details (and notes about my sanity)
still a bit of cleanup to do
Note: only qb-core with qs-inventory and qb-target is supported as that's the only setup I have and havn't tested the rest. Note that I've left spaces with comments such as "add ESX logic" for future commiters to setup their systems.