Skip to content

Conversation

@rouing
Copy link
Contributor

@rouing rouing commented Jan 8, 2025

Refactoring to use a "HAL" which will abstract and provide a common library definition for all hardware.

Namespace: HAL
Namespace Inner: Device Type (PMIC, RTC, etc)
Driver: Device Model (AXP2101, etc)

This is a draft for now.

@rouing rouing marked this pull request as draft January 8, 2025 22:05
@JulianVolodia
Copy link

regarding this if I port to new device should I follow that PR too? I crafted with fast lane vibing https://www.waveshare.com/wiki/ESP32-S3-Touch-LCD-2 support last days, but I am little bit rusty if it comes to porting ;)

I reviewed the code a little bit, I think there is one uncommented line unnecesairly but tell me if You want me to mark it what I think

Thanks

@emericklaw
Copy link
Member

regarding this if I port to new device should I follow that PR too? I crafted with fast lane vibing https://www.waveshare.com/wiki/ESP32-S3-Touch-LCD-2 support last days, but I am little bit rusty if it comes to porting ;)

I reviewed the code a little bit, I think there is one uncommented line unnecesairly but tell me if You want me to mark it what I think

Thanks

This is a very old PR that has not been merged. You should follow the wiki https://github.com/BruceDevices/firmware/wiki/FAQ#port-to-other-boards and when submitting a PR use the dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.