Merged
Conversation
…rnType - Replace simulateTransaction + borrow_cap_mut with stateService.getCoinInfo - PTB cannot pass &mut references between commands; SDK v2 validates and rejects - Add getUsdbSupply e2e test (expect supply > 0) Made-with: Cursor
…ness getAllOraclePrices with all coin types fails on main's static config (derivative flow / Hermes batch). Single-coin getOraclePrices(SUI) is stable and sufficient to validate the oracle flow. Also add SUI_GRPC_URL env support for custom RPC. Made-with: Cursor
Made-with: Cursor
bucket-bot
approved these changes
Mar 5, 2026
Collaborator
bucket-bot
left a comment
bucket-bot
left a comment
There was a problem hiding this comment.
Code review
Root cause fix is correct — PTB 無法在 commands 之間傳遞 &mut references，改用 stateService.getCoinInfo 是正確方向。
Checked:
- ✅ Bug detection: fix 邏輯正確，無新引入 regression
- ✅ Silent failure: fallback 範圍縮小（只有 treasury undefined 才 return 0n，舊的任何 PTB 錯誤都 return 0n）
- ✅ Test quality:
getUsdbSupply斷言從>= 0n→> 0n，直接抓到這次 bug - ✅ Oracle 測試縮窄有文件說明，合理
一個小 note（非 blocker）: mvr.resolveType 多了一次 RPC round-trip，如果 getCoinInfo 其實接受 raw type 的話可以省掉。但如果需要 MVR 正規化才能 lookup 的話就沒問題，不影響正確性。
🤖 Generated with Jarvis (OpenClaw)
zasper32171
approved these changes
Mar 9, 2026
CJMario89
approved these changes
Mar 9, 2026
JustaLiang
reviewed
Mar 9, 2026
| describe('Oracle', () => { | ||
| it( | ||
| 'getAllOraclePrices returns positive numbers for all oracle coin types', | ||
| 'getOraclePrices returns positive numbers for SUI (validates oracle flow)', |
Contributor
Author
There was a problem hiding this comment.
先前因為避開 sCoin 升級問題修改，已經在 commit 382a46e
中加回，測試通過
…Type, use original only) Made-with: Cursor
- Update scoin_rule::feed target to 0xb7c07926... (from query-outputs PRICE_OBJS) - Align static config with merge branch test-results/query-outputs.json - Restore strict getAllOraclePrices test assertions Made-with: Cursor
JustaLiang
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
getUsdbSupplyfailing withInvalidPublicFunctionReturnTypeafter upgrading to SDK v2. Circulating supply was showing 0 in the frontend.Root Cause
Sui PTBs cannot pass references (
&or&mut) between commands. The old flow:usdb::borrow_cap_mut(treasury)→ returns&mut BorrowCap0x2::coin::total_supply(that)→ uses that referenceWith
@mysten/suiv2,simulateTransactionenforces this and returnsInvalidPublicFunctionReturnType. The code fell back toreturn 0n, so the frontend saw 0.Solution
Replace the PTB-based flow with
stateService.getCoinInfoto read TreasuryCap total supply directly (no PTB).Changes
getUsdbSupplyto usegetCoinInfo; fix eqeqeq lintTesting
pnpm build✓pnpm lint✓pnpm vitest run test/e2e/client.test.ts✓