test: align Pyth mocks with listDynamicFields; relax e2e market OI; match USDC error copy#12
Merged
JustaLiang merged 5 commits intomainfrom Apr 7, 2026
Merged
Conversation
… error copy Made-with: Cursor
- Replace fixed longOi expectations with bigint + non-negative checks - Add expectMarketOiFieldsParsed helper to catch missing/wrong types Made-with: Cursor
- Remove unused BaseAsset import and WLP_TYPE from setup-oracle.ts - Apply prettier --write across src, test, scripts per lint:prettier Made-with: Cursor
Made-with: Cursor
bucket-bot
approved these changes
Apr 3, 2026
Contributor
bucket-bot
left a comment
bucket-bot
left a comment
There was a problem hiding this comment.
Code review
No issues found. Checked for bugs and CLAUDE.md compliance.
🤖 Generated with Rex (OpenClaw)
bucket-bot
approved these changes
Apr 3, 2026
Contributor
bucket-bot
left a comment
bucket-bot
left a comment
There was a problem hiding this comment.
Code review
No actionable issues found. Here's a summary of what was checked:
What this PR does: Pure test alignment + formatter pass — no production logic changes. Three areas updated:
- Pyth unit tests now mock
listDynamicFields(withchildId+valueType) to match the already-merged gRPC-oriented production code path;getDynamicFieldsis gone. - Several tests that previously expected success now correctly expect
/Price table not found/— this tightens requirements:childIdis required (notobjectId),valueTypemust be non-empty (not substituted byobjectType). - E2E OI assertions relaxed from hardcoded
0n/1ntoexpectMarketOiFieldsParsed— correct approach for a live testnet.
Agents run:
- ✅ Bug Detection — no logic changes in src/ (formatting only); test behavioral changes are intentional and aligned with prior production code updates
- ✅ CLAUDE.md Compliance — naming conventions respected, import ordering follows style
- ✅ Silent Failure Hunter — no new try/catch or error suppression introduced
- ✅ Comment Accuracy — test descriptions updated to accurately reflect new expected behavior
- ⏭️ Dependency Security — no package.json changes
- ⏭️ Type Design — no new types added
Decision: ✅ Approved — clean test housekeeping, no issues ≥ 80 confidence.
🤖 Generated with Jarvis (OpenClaw)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch updates tests in three areas: