Update Pokedex list to move 10 and 25 (Left/Right, L/R)#301
Open
BloxMaster wants to merge 7 commits into
Open
Conversation
Improved Audio Engine, Repel reuse ask, medicine reuse ask, debug menu basic implementation.
Changes using left or right on the pokedex to move 10 instead of 7 (expected behavior for menus in the game), and adds the ability to use L or R to move 25 slots in the list- which should help navigate what can become a very large list quickly. Changes all of these to work when held (as up and down do).
Previously, you could not immediately exit the cave entrance unless you moved a tile in any direction first. This changes that tile to match the layer of the rest of the floor (3) instead of being a transition tile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes using left or right on the Pokedex listing to move 10 instead of 7 (expected behavior for menus in the game), and adds the ability to use L or R also in order to move 25 slots in the list- which should help navigate what can become a very large list quickly. Changes all of these to work when held (as up and down do). I don't foresee any conflicts with this, and from my test it just seems to 'work'. Hopefully!
PS, this is my first pull request, so apologies in advance!
I'm on Discord as Blox as an additional note if you need me.