Skip to content

docs: refresh CONTRIBUTING + add issue/PR templates - #21

Merged
Burton-David merged 1 commit into
mainfrom
docs/contrib-templates
May 13, 2026
Merged

docs: refresh CONTRIBUTING + add issue/PR templates#21
Burton-David merged 1 commit into
mainfrom
docs/contrib-templates

Conversation

@Burton-David

Copy link
Copy Markdown
Owner

Summary

Newcomer-facing polish so outside contributors hit fewer paper cuts.

CONTRIBUTING.md correctness fixes

  • Test count was hardcoded as "67 unit + 1 e2e" — suite is now 513 passed + 14 skipped. Replaced with a description of what each command runs (counts drift, descriptions don't).
  • Protocol count was "four" in two places; we're at nine (Source / Index / Embedder / CitationRenderer / Reranker / ClaimExtractor / Chunker / CitationScorer / PaperAnalyzer).
  • Async-everywhere convention now names the I/O-bound vs CPU-bound protocols so contributors don't add async theatre to a Chunker.
  • "Adding a new X" was a single line listing four protocols. Now a 9-row table with package paths and a numbered checklist covering test + re-export + wiring + docs.

Issue templates (.github/ISSUE_TEMPLATE/)

  • `bug_report.yml` — structured fields for repro / env / logs.
  • `feature_request.yml` — problem-first framing, scope dropdown.
  • `config.yml` — disables blank issues, routes usage questions to Discussions and points at existing roadmap / good-first-issue queries.

PR template (.github/pull_request_template.md) — matches CONTRIBUTING's existing "Test plan" convention so reviewers see consistent PR bodies.

Closed #5 separately — it was shipped in #12 and would have wasted a newcomer's time.

Test plan

  • `pytest -q` — 513 passed, 14 skipped (doc-only change, no behavior).

- CONTRIBUTING.md updates:
  * Test-count line dropped its hard-coded "67 unit + 1 e2e" (was wrong;
    suite is now 513+) in favor of a description of what each command
    runs.
  * "four protocols" → "nine protocols" everywhere it appeared. The
    async-everywhere convention now lists the I/O-bound protocols
    explicitly so newcomers know Chunker/CitationRenderer stay sync
    on purpose.
  * "Adding a new Source / Index / Embedder / CitationRenderer" expanded
    to a 9-row table covering every protocol with its package path,
    and the steps now name `tests/conftest.py` real fakes explicitly.

- .github/ISSUE_TEMPLATE/ added:
  * bug_report.yml — structured fields for repro, env, logs.
  * feature_request.yml — problem-first framing, scope dropdown.
  * config.yml — disables blank issues, routes usage questions to
    Discussions and existing roadmap/good-first-issue queries.

- .github/pull_request_template.md added — matches the "Test plan"
  convention CONTRIBUTING.md already requires. Comment block reminds
  contributors of the branching + squash-merge rules without being
  preachy in the rendered PR body.
@Burton-David
Burton-David merged commit 5506aed into main May 13, 2026
1 check passed
@Burton-David
Burton-David deleted the docs/contrib-templates branch May 13, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Citation graph tools: find_referenced_works / find_related

1 participant