Skip to content

fix(cli): fix NameError for reference_view_strategy in CLI commands#263

Closed
connorsoohoo wants to merge 1 commit into
ByteDance-Seed:mainfrom
connorsoohoo:fix-ref-view-cli
Closed

fix(cli): fix NameError for reference_view_strategy in CLI commands#263
connorsoohoo wants to merge 1 commit into
ByteDance-Seed:mainfrom
connorsoohoo:fix-ref-view-cli

Conversation

@connorsoohoo

Copy link
Copy Markdown

This PR fixes a NameError / TypeError in the CLI subcommands ('image', 'images', 'colmap', 'video') where 'reference_view_strategy' was passed to 'run_inference' instead of the defined parameter name 'ref_view_strategy'.

Testing Instructions

  1. Run any CLI command that triggers one of these subcommands (for example, the 'colmap' subcommand) with a specific strategy:
    da3 colmap /path/to/colmap_dir --ref-view-strategy saddle_balanced
  2. Verify that it executes and passes the parameter to the inference engine without throwing a NameError: name 'reference_view_strategy' is not defined crash.

Correct reference_view_strategy to ref_view_strategy when calling run_inference in the image, images, colmap, and video commands to match the parameter name defined in run_inference.
@connorsoohoo

Copy link
Copy Markdown
Author

closing as dupe of #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant