fix(cli): fix NameError for reference_view_strategy in CLI commands#263
Closed
connorsoohoo wants to merge 1 commit into
Closed
fix(cli): fix NameError for reference_view_strategy in CLI commands#263connorsoohoo wants to merge 1 commit into
connorsoohoo wants to merge 1 commit into
Conversation
Correct reference_view_strategy to ref_view_strategy when calling run_inference in the image, images, colmap, and video commands to match the parameter name defined in run_inference.
Author
|
closing as dupe of #220 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a NameError / TypeError in the CLI subcommands ('image', 'images', 'colmap', 'video') where 'reference_view_strategy' was passed to 'run_inference' instead of the defined parameter name 'ref_view_strategy'.
Testing Instructions
NameError: name 'reference_view_strategy' is not definedcrash.