Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuff #8

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stuff #8

wants to merge 2 commits into from

Conversation

petergiuntoli
Copy link

  • Avoid adding table to tables list twice
  • Make StorageType readonly

public Type Type { get; private set; }
public ulong Value { get; private set; }
public bool IsRelation { get; private set; }
public readonly Type Type;
Copy link

@thygrrr thygrrr Jan 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest simpler change:

    public required Type Type { get; init; }
    public required ulong Value { get; init; }
    public required bool IsRelation { get; init; }

(done! all below changes unnecessary)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't compile in unity since it only has C# 9.0 support and this is a C# 11.0 feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants