Skip to content

initialize structure of repository with tests, formatter #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 18, 2024
Merged

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Jul 19, 2024

Initialized the repo based on hatch for testing, formatting, linting, environment management, and as building system. We are using mostly hatch defaults to not make complicated pyproject.toml so it is easier to maintain which are ruff as formatter and linter and pytest for tests. For the documentation I set up sphinx. The idea would be use sphinx with MyST so it is easier to maintain as we can just write markdown files. Because hatch cannot interpret the org file I changed the README file to rst, since we can integrate it better with the sphinx docs. Added basic developer information about developer tools to the README.

TODOs/Issues:

  • The CI currently is invoked twice. I think the CI should be
  push:
    branches: [main]
  pull_request:
    # Check all PR

But then it only gets active after this PR is merged, so might change this in a future PR

@agoscinski agoscinski marked this pull request as ready for review July 19, 2024 20:17
@agoscinski agoscinski force-pushed the init-repo branch 4 times, most recently from b12c52e to b35576c Compare July 24, 2024 07:35
Using for testing, formatting, linting defaults from hatch.

Set up simple CI that checks tests and formatting.

Changed README to rst because built system cannot interpret org
files.

Set up simple sphinx documentation structure that includes the README
install section.

Updated README with usage of basic developer tools.
Co-authored-by: Rico Haeuselmann <[email protected]>
…change python versions to github context everywhere
authors = [
{name = 'Matthieu Leclair', email = '[email protected]'},
{name = 'Julian Geiger', email = '[email protected]'},
{name = 'Alexander Goscinski', email = '[email protected]'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   {name = 'Rico Haüselmann', email = '[email protected]' },

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{name = 'Alexander Goscinski', email = '[email protected]'},
{name = 'Alexander Goscinski', email = '[email protected]'},
{name = 'Rico Haüselmann', email = '[email protected]' },

dynamic = ["version"]
description = 'WcFlow a library for creating weather and climate workflows.'
authors = [
{name = 'Matthieu Leclair', email = '[email protected]'},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[email protected] (trying to switch all my email addresses to this one)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{name = 'Matthieu Leclair', email = 'matthieu.leclair@env.ethz.ch'},
{name = 'Matthieu Leclair', email = 'matthieu.leclair@c2sm.ethz.ch'},

@leclairm leclairm merged commit 863ce52 into main Sep 18, 2024
3 checks passed
@agoscinski agoscinski deleted the init-repo branch January 9, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants