Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup metrics fields and factory tests (cont) #690

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

halungge
Copy link
Contributor

@halungge halungge commented Mar 4, 2025

Register two additional fields in the metrics factory, which had verification tests in test_metric_fields.py but were not registered in the factory and rename and move very general programs out of metric_fields.py. Field verification is now done within the factory tests, StencilTests added for the generic functions in math_helpers.py.

additional changes:

  • delete __init__.py from common/tests
  • replace computation of input z_mc with field from serializer in tests.

@halungge halungge marked this pull request as ready for review March 4, 2025 16:12
@halungge
Copy link
Contributor Author

halungge commented Mar 4, 2025

cscs-ci run default

@halungge halungge changed the title Cleanup metrics fields and factory tests Cleanup metrics fields and factory tests (cont) Mar 4, 2025
@halungge halungge requested a review from nfarabullini March 4, 2025 16:14
@halungge
Copy link
Contributor Author

halungge commented Mar 5, 2025

cscs-ci run default

@halungge
Copy link
Contributor Author

halungge commented Mar 5, 2025

cscs-ci run default

1 similar comment
@halungge
Copy link
Contributor Author

halungge commented Mar 5, 2025

cscs-ci run default

@halungge
Copy link
Contributor Author

halungge commented Mar 6, 2025

cscs-ci rund

@halungge
Copy link
Contributor Author

halungge commented Mar 6, 2025

cscs-ci run

@halungge
Copy link
Contributor Author

halungge commented Mar 6, 2025

cscs-ci run default

Copy link

github-actions bot commented Mar 6, 2025

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@halungge
Copy link
Contributor Author

halungge commented Mar 6, 2025

cscs-ci run default

2 similar comments
@halungge
Copy link
Contributor Author

cscs-ci run default

@halungge
Copy link
Contributor Author

cscs-ci run default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants