Enable GTIR-DaCe backend #696
Conversation
This reverts commit f500f93.
|
One diffusion test is failing because we need GridTools/gt4py#1939 |
edopao
force-pushed
the
update_to_gtir_dace_concat_where
branch
from
3144465 to
6b4dfff
Compare
|
cscs-ci run dace |
|
cscs-ci run default |
1 similar comment
|
cscs-ci run default |
model/atmosphere/diffusion/src/icon4py/model/atmosphere/diffusion/diffusion.py
Outdated
Show resolved
Hide resolved
model/atmosphere/dycore/src/icon4py/model/atmosphere/dycore/solve_nonhydro.py
Outdated
Show resolved
Hide resolved
| @@ -431,6 +431,8 @@ def test_run_diffusion_single_step( | |||
| ): | |||
| if orchestration and not helpers.is_dace(backend): | |||
| pytest.skip("Orchestration test requires a dace backend.") | |||
| if orchestration and data_alloc.is_cupy_device(backend): | |||
There was a problem hiding this comment.
Question: is this a general issue or only the orchestration does not work on GPU?
There was a problem hiding this comment.
only the dace orchestration
| @@ -394,6 +395,7 @@ def test_factory_pg_edgeidx_dsl(grid_savepoint, metrics_savepoint, grid_file, ex | |||
| (dt_utils.R02B04_GLOBAL, dt_utils.GLOBAL_EXPERIMENT), | |||
| ], | |||
| ) | |||
| @pytest.mark.cpu_only | |||
There was a problem hiding this comment.
Question: do they fail or they are just horribly slow?
There was a problem hiding this comment.
I am not 100%, but I remember I saw a segfault (some time ago). I could try on the latest main, or after your PR #681 is merged.
There was a problem hiding this comment.
These two test cases have very similar names. The first (test_factory_pg_edgeidx_dsl) fails on GPU, with an error that suggests some numpy/cupy issue. The second (test_factory_pg_exdist_dsl) seems to have some tolerance issue in result validation.
See latest CI run:
https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/5125340235196978/2255149825504671/-/jobs/9627731793
…o update_to_gtir_dace_concat_where
|
cscs-ci run dace |
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run dace |
This PR enables testing with the GTIR-DaCe backend.
icon4py_staging_20250403