Skip to content

Conversation

@superswan
Copy link

sed dependency doesn't work well with windows. I've tried using a sed binary on Windows and didn't have great results. This PR removes dependence on sed and applies replacements using the Python standard lib.

I changed the name of the screenshot file as well because I found it pretty annoying for tab completion.

@eltrevii
Copy link

eltrevii commented Nov 17, 2022

why did you remove the first part of the code?

@superswan
Copy link
Author

Do you mean realTimeMuxER() function? It has been removed because the replacements are now being made in python and not using sed command. Before, this function was used as a helper function to do text cleanup and make the replacements by running the sed commands in a parallel process.

In my testing this has had little to no performance impact and doesn't affect the output script.

The #!/usr/bin/env python3 shebang was removed for portability reasons

@eltrevii
Copy link

@superswan i mean the first comment
image

@eltrevii
Copy link

and the #!/usr/bin/env python3 is used in linux to determine the version (python 3) and it doesnt affect windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants