[FEATURE] expand fan and temperature control APIs, add tests and docs #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactored C ectool functions to return error codes instead of printing or exiting. * Added standard error codes (e.g. `EC_ERR_INIT`, `EC_ERR_READMEM`). * Introduced a C++ `ECController` class to wrap the C API, throwing C++ exceptions with clear error messages. * Exposed `ECController` to Python using pybind11 bindings. * Updated CMake to support the new C++ and pybind11 build flow.
- Implement ec_get_fan_rpm() to read RPM for a specific fan - Implement ec_get_all_fan_rpm() to read RPMs for all fans at once - Implement ec_set_fan_target_rpm() to set RPM for a specific fan - Implement ec_set_all_fan_target_rpm() to set RPM for all fans
[FEATURE] Expose more ectool functions in pyectool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a major API overhaul and prepares the codebase for v0.2.0 release.
API Changes
Refactor: from functions to class-based interface
We’ve moved from standalone functional calls to a structured, class-based API via
ECController.This improves maintainability and aligns with typical Pythonic design.
Old Approach:
New Approach:
New Capabilities
Fan Control:
Temperature Monitoring:
get_temp_info(sensor_idx).Documentation Updates
ECController.ECTempInfo.Tests Added
get_fan_rpm,get_temp, etc.) against rawectooloutput to ensure API correctness and consistency.