Skip to content

Added access level info for members in Project Members page #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

jupiter007
Copy link
Collaborator

Description

  • Added missing access level info to Project Members page
    Fixes # (368)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually tested and added unit tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I updated the CHANGELOG.md and added documentation if necessary
  • I have added tests that prove my fix is effective or that my feature works
  • I have completed manual or automated accessibility testing for my changes
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
    -- NOTE: There are backend changes to return access levels that are currently in PR review (245)

Copy link
Collaborator

@fraserclark fraserclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about using routePath() but approved anyway as it is a minor detail

const isLoading = loading || projectCollaboratorsLoading;
const isError = projectContributorError || projectCollaboratorsError;

const handleAddContributors = (): void => {
// Handle adding new collaborator
router.push(`/projects/${projectId}/members/search`);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good place to use our recent routePath addition

routePath("projects.members.search",projectId )

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes. Thanks for catching that @fraserclark . I will definitely update that before merging.

@jupiter007 jupiter007 marked this pull request as draft April 1, 2025 18:48
@jupiter007
Copy link
Collaborator Author

I'm converting this temporarily to Draft mode until we get more clarity on how we want to handle getting access levels from projectCollaborators. Currently, I implemented it by adding userId to tie project contributors to the access levels, but it sounds like that won't work. We need to think of a better way. Possibly by adding an ORCiD search?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants