Skip to content

DRAFT: Accessibility changes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nichgray wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

DRAFT: Accessibility changes #2

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4cc068
add aria-label
nichgray Apr 3, 2026
c3a7d19
add dynamic aria-label to pagination
nichgray Apr 3, 2026
0285c9e
add id to pagination nav
nichgray Apr 10, 2026
cc84cef
adjust nav to allow distinct labels for top and bottom pagination
nichgray Apr 10, 2026
acf5d45
giving up on adding unique label to nav and moving that element to pr…
nichgray Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/solr_helpers/pagination.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ def paginator(total_pages, display_range=3, aParams=params)
new_params.delete("facet.field")
if total_pages && total_pages.to_i > 1
current_page = new_params["page"] ? new_params["page"].to_i : 1
html = "<nav><ul class='pagination'>"
html = "<ul class='pagination'>"
html += page_button_previous(current_page, new_params)
html += paginator_numbers(total_pages, display_range, new_params)
html += page_button_next(current_page, total_pages, new_params)
html += "</ul></nav>"
html += "</ul>"
return html.html_safe
end
end
Expand Down Expand Up @@ -80,7 +80,7 @@ def page_button_previous(current_page, aParams)
html = ""
html += (current_page == 1) ? "<li class='disabled'>" : "<li>"
if current_page != 1
html += link_to "<span aria-hidden='true'>&laquo;</span>".html_safe, to_page(current_page-1, aParams)
html += link_to "<span aria-label='Previous Page (#{current_page-1})'>&laquo;</span>".html_safe, to_page(current_page-1, aParams)
else
# use a span instead of a link if it is inactive
html += "<span><span aria-hidden='true'>&laquo;</span></span>"
Expand All @@ -96,7 +96,7 @@ def page_button_next(current_page, total_pages, aParams)
html = ""
html += (current_page == total_pages) ? "<li class='disabled'>" : "<li>"
if current_page != total_pages
html += link_to "<span aria-hidden='true'>&raquo;</span>".html_safe, to_page(current_page+1, aParams)
html += link_to "<span aria-label='Next Page (#{current_page+1})'>&raquo;</span>".html_safe, to_page(current_page+1, aParams)
else
html += "<span><span aria-hidden='true'>&raquo;</span></span>"
end
Expand Down