Open
Conversation
sloriot
added
Not yet approved
afabri
requested changes
Feb 2, 2026
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
afabri
reviewed
Feb 2, 2026
Co-authored-by: Andreas Fabri <andreas.fabri@geometryfactory.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
MaelRL
reviewed
Feb 2, 2026
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
This comment was marked as outdated.
This comment was marked as outdated.
|
The documentation is built. It will be available, after a few minutes, here: https://cgal.github.io/6557/v5/Manual/index.html |
MaelRL
reviewed
Feb 6, 2026
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
sloriot
added
Tested
Check size
and removed
CHANGES.md not updated
TODO
Under Testing
labels
Member
Author
|
Successfully tested in CGAL-6.2-Ic-108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add convex hull do-intersect predicates based on this paper.
Release Management
TODOs:
separation_distance()--> I don't see big differences with the original method, I don't think is relevant with exact computations.
--> Computing OBBs is significantly slower than computing convex hulls and their hierarchies, and applying transformations is difficult with exact computations. Therefore, using do_intersect() on the convex hulls or on the hierarchies is sufficiently fast in this context.
Installation/changes.md