Introduce geometrically NM detection functions#6968
Open
Introduce geometrically NM detection functions#6968
Conversation
It is usually small since it has the size of the non-manifold vertices.
MaelRL
added
Not yet approved
sloriot
reviewed
Oct 17, 2022
| /// \return the output iterator. | ||
| template <typename PolygonMesh, typename OutputIterator, | ||
| typename NamedParameters = parameters::Default_named_parameters> | ||
| OutputIterator geometrically_non_manifold_edges(const PolygonMesh& pmesh, |
Member
There was a problem hiding this comment.
You should check Polygon_mesh_processing/include/CGAL/Polygon_mesh_processing/Non_manifold_feature_map.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Introduce two new PMP functions to collect geometrically non-manifold elements. Also speed up
non_manifold_vertices()for the average case.Some misc fixes along the way.
TODO:
Release Management
PMP