-
Notifications
You must be signed in to change notification settings - Fork 28
Final Submission #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
micallef25
wants to merge
53
commits into
CIS565-Fall-2019:master
Choose a base branch
from
micallef25:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Final Submission #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/micallef25/Project5-DirectX-Procedural-Raytracing
Features
I emplemented all the TODO’s with minimal tears and without throwing my laptop out the window. Thank you Ziad.
Feedback:
Pros: As a non CG student I found the implementation differences between the path tracer and this path tracer to be rather interesting for example ray marching was fun to implement. The conceptual questions were also very nice. I took this class to dabble with GPU's and learn about computer graphics. And finally after like 3 months in I learned something useful about CG.
Cons: I found myself to be extremely frustrated through out the project. I think others did as well.
There is no correlation to what we are learning in class to our projects. I feel as I am being equipped with the necessary tools to finish a project in a reasonable amount of time. Instead I spend hours a day on the projects. I feel as if the professor is not preparing me at all. I learned more about CG from Ziad in one hour than the professor all semester.
How is this project going the be supported without Ziad? you can’t build projects based off of students final projects how can TA’s support this? It is not plausible. I pay 7000 dollars for well thought out projects not a project that was put together 3 weeks before hand by a student. Ziad may be smart but it is the responsibility of the professor to create well thought out projects. This is the second new project and frankly both have been debilitating.
There was not enough background knowledge to understand alot of the CPU setup. Some of it was straight forward but other parts it seemed like it was more of a "well that is what it is". It is hard for TA's to properly help students without just giving them the one line of code needed to fix everything.
I found it extremely irresponsible to release this project with the amount of school computers vs the amount of kids that needed school computers. You knew in homework 0 how many students did not have the hardware and this was ignored. That is completely unacceptable.