Added potential energy to the MultiHMCGibbsState#10
Merged
Conversation
The potential energy is taken from the existing HMCstate after all Gibbs steps are taken.
Increased absolute tolerances due to updated Numpyro.
Increased tolerances futher, as required by the updated version of Numpyro.
CKrawczyk
approved these changes
Jul 25, 2025
Owner
CKrawczyk
left a comment
CKrawczyk
left a comment
There was a problem hiding this comment.
These changes work as intended. In the long run it will be nice to get the likelihood evaluations as well, but as that is not automatically saved in the HMC state it would need much more code to get at it in a clean way. That would be beyond this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The potential energy is taken from the existing HMCstate after all Gibbs steps are taken.