Ab2d-6495/http post to bfd #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ab2d-bfd/src/main/java/gov/cms/ab2d/bfd/client/BFDSearchImpl.java # ab2d-bfd/src/test/java/gov/cms/ab2d/bfd/client/BlueButtonClientSTU3Test.java # build.gradle
bennavapbc
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/AB2D-6495
🛠 Changes
Changed HttpGet request to HttpPost request
_count encoded as a Query String as part of the POST Request
ℹ️ Context
There is a bug, potentially in HAPI FHIR, but ultimately, that's a problem for us in BFD.
There is a required change for AB2D's (and any partner adopting POST requests to BFD for Patient/_search ) whenever pagination is requested with _count. At a minimum, _count needs to be in encoded as a Query String as part of the POST Request, e.g. /v2/fhir/Patient/_search?_count=100.
🧪 Validation