Create ACO Admin Task (Lambda and Workflows) #1043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds github workflows for dev, test, prod deployment of lambda. Adds github workflow for test integration.
austincanada
changed the title
| workflow_dispatch: | ||
| push: | ||
| branches: | ||
| - austin/BCDA-8629-create-aco-wf |
There was a problem hiding this comment.
Once all changes are done this should change to 'main'
| echo "STARTTIME=`date +%s`" >> "$GITHUB_OUTPUT" | ||
| aws lambda invoke --function-name bcda-dev-admin-create-aco \ | ||
| --cli-binary-format raw-in-base64-out \ | ||
| --payload '{"name":"Test ACO","cms_id":"testcms"}' test-result.txt |
There was a problem hiding this comment.
This will be creating the same ACO each time its called. Do we need to do some kind of clean up? What happens when we call create ACO with an existing ACO by that name/cms_id?
There was a problem hiding this comment.
That is a good point; do we want to add a cleanupACO type function in this lambda where the removal occurs? We could potentially configure it by saying that if it's running in a non-prod env, then run the cleanup afterwards?
There was a problem hiding this comment.
Looking into it currently.
|
Cant fully review until the checks are all passing but looking good so far! |
austincanada
changed the title
Changes the entries of opensbx to sbx Renames the slack error nested within another error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8629
🛠 Changes
Added lambda for Create ACO tasks.
Added workflows to run integration tests and deploy lambda to envs.
Made cli action, CreateACO, an export.
Linter added cli updates.
ℹ️ Context
Since we are moving off of Jenkins, we need to create lambdas for certain actions and tasks.
🧪 Validation
Verifying through workflows.