-
Notifications
You must be signed in to change notification settings - Fork 26
Brandon/bb2 3951 saving unhashed mbi #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…using errors in unit tests
…using errors in unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, and seem to work well, but the second AC on the ticket still needs to be addressed, which is to have the FHIR ID updated when updated from BFD during token refresh (the ticket looks like it mistakenly said to update the MBI). You can test this by doing an auth flow, then updating the FHIR ID in the crosswalk table, and then refreshing the access token. Currently, it'll continue to use the "wrong" FHIR ID, but we would want it to get updated in the crosswalk.
Also, we probably want this reviewed by the security team as well since it involved adding PII to the database and Django admin view.
JIRA Ticket:
BB2-3951
What Does This PR Do?
Adds a column for the unhashed mbi in the bluebutton_crosswalk table. This will not be actively populated yet.
What Should Reviewers Watch For?
Any possible areas of our databases that have been overlooked with this
Validation
Run a local instance and connect to the local postgres db using your database manager of choice. Verify that the user_mbi column appears as expected.
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)