Skip to content

Brandon/bb2 3951 saving unhashed mbi #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

bwang-icf
Copy link
Contributor

@bwang-icf bwang-icf commented Jul 7, 2025

JIRA Ticket:
BB2-3951

What Does This PR Do?

Adds a column for the unhashed mbi in the bluebutton_crosswalk table. This will not be actively populated yet.

What Should Reviewers Watch For?

Any possible areas of our databases that have been overlooked with this

Validation

Run a local instance and connect to the local postgres db using your database manager of choice. Verify that the user_mbi column appears as expected.

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies
  • Modifies any security controls
  • Adds new transmission or storage of data
  • Any other changes that could possibly affect security?
  • Yes, one or more of the above security implications apply. This PR must not be merged without the ISSO or team
    security engineer's approval.

Any Migrations?

  • Yes, there are migrations
    • The migrations should be run PRIOR to the code being deployed
    • The migrations should be run AFTER the code is deployed
    • There is a more complicated migration plan (downtime,
      etc)
  • No migrations

@bwang-icf bwang-icf marked this pull request as ready for review July 15, 2025 17:35
@jimmyfagan jimmyfagan self-assigned this Jul 16, 2025
Copy link
Contributor

@jimmyfagan jimmyfagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, and seem to work well, but the second AC on the ticket still needs to be addressed, which is to have the FHIR ID updated when updated from BFD during token refresh (the ticket looks like it mistakenly said to update the MBI). You can test this by doing an auth flow, then updating the FHIR ID in the crosswalk table, and then refreshing the access token. Currently, it'll continue to use the "wrong" FHIR ID, but we would want it to get updated in the crosswalk.

Also, we probably want this reviewed by the security team as well since it involved adding PII to the database and Django admin view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants