Jamesdemery/bb2 4190 ensure consistent 404 responses #1408
+46
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-4190
What Does This PR Do?
Ensures consistent 404 responses for when a user runs a patientV2 call for a fhir_id they are not associated with or for a fhir_id that does not exist. Previously, two different error messages were reported.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
Validation
Ensure the new unit tests, test_read_on_different_fhir_id_than_associated_with_token and test_read_on_fhir_id_that_does_not_exist cover the cases that we want.
Open Postman, run the following cases and confirm both return a 404 with detail = 'Not found.':
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
security engineer's approval.
Any Migrations?
etc)