Refactoring src/topics/tags.js#103
Open
DachiCharkviani wants to merge 3 commits into
Open
Conversation
|
Pull Request Test Coverage Report for Build 10724248550Details
💛 - Coveralls |
Author
|
resolves #94 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executed the refactoring demand, additionally added test cases for the code I wrote (they all pass), my code is covered by the test coverage (test coverage percentage for the file went up, from 90 to 92.25), and checked through console log whether or not what I added worked!
I checked console logs through creating a new topic post. In the post I simply tagged myself and posted it. This executed printing my Andrew id in the nodebb log since one of the functions I refactored was about creating tags!
Resolved #94