Skip to content

Refactoring nesting code in src/user/delete.js issue #54 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
T7alabdullah wants to merge 2 commits into
base: f24
Choose a base branch
from
Open

Refactoring nesting code in src/user/delete.js issue #54 #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5f72e6
Reworked the updateCount function and moved it to avoid the nesting i…
T7alabdullah Sep 4, 2024
29cf1f3
added logs inthe updateCount function for testing
T7alabdullah Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions src/user/delete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,21 @@ const messaging = require('../messaging');
const plugins = require('../plugins');
const batch = require('../batch');

async function updateCount(uids, name, fieldName) {
console.log('Talal: Starting updateCount function');
await batch.processArray(uids, async (uids) => {
const counts = await db.sortedSetsCard(uids.map(uid => name + uid));
const bulkSet = counts.map(
(count, index) => ([`user:${uids[index]}`, { [fieldName]: count || 0 }])
);
await db.setObjectBulk(bulkSet);
}, {
batch: 500,
});
console.log('Talal: Finished updateCount function');
}


module.exports = function (User) {
const deletesInProgress = {};

Expand Down Expand Up @@ -208,17 +223,6 @@ module.exports = function (User) {
db.getSortedSetRange(`following:${uid}`, 0, -1),
]);

async function updateCount(uids, name, fieldName) {
await batch.processArray(uids, async (uids) => {
const counts = await db.sortedSetsCard(uids.map(uid => name + uid));
const bulkSet = counts.map(
(count, index) => ([`user:${uids[index]}`, { [fieldName]: count || 0 }])
);
await db.setObjectBulk(bulkSet);
}, {
batch: 500,
});
}

const followingSets = followers.map(uid => `following:${uid}`);
const followerSets = following.map(uid => `followers:${uid}`);
Expand Down