Added suggestion name for username-taken error message#19
Open
IndyaG wants to merge 3 commits intoCMU-17313Q:mainfrom
Open
Added suggestion name for username-taken error message#19IndyaG wants to merge 3 commits intoCMU-17313Q:mainfrom
IndyaG wants to merge 3 commits intoCMU-17313Q:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I added an improved error message for the case where a user tries to register with a username that's already taken. The message now suggests an alternative username by appending a static suffix (e.g.,
username123becomesusername123suffix)Testing
Tested locally by running NodeBB and executing the updated code using these commands:
npm install -g grunt-cli./nodebb build./nodebb restart