Skip to content

Refactor(user/info): issue 15#18

Open
dkhalifa25 wants to merge 2 commits into
CMU-17313Q:mainfrom
dkhalifa25:issue_15_refactor
Open

Refactor(user/info): issue 15#18
dkhalifa25 wants to merge 2 commits into
CMU-17313Q:mainfrom
dkhalifa25:issue_15_refactor

Conversation

@dkhalifa25
Copy link
Copy Markdown

13 Function with many returns (count = 8): exports

Review each of the return statements and reduce total return count.

Resolved #15

Comment thread src/user/info.js
* No nested function literals with `return` inside this body.
*/
module.exports = function (User) {
// Temporary runtime proof (uncomment when you do the screenshot), then remove before commit:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kek

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17518116144

Details

  • 81 of 84 (96.43%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 78.528%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/user/info.js 81 84 96.43%
Totals Coverage Status
Change from base Build 17514140671: -0.001%
Covered Lines: 24693
Relevant Lines: 29608

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor (src/user/info.js)

3 participants