Reduced complexity in the file scr/controllers/recent.js#32
Open
mfahad2 wants to merge 1 commit intoCMU-17313Q:mainfrom
Open
Reduced complexity in the file scr/controllers/recent.js#32mfahad2 wants to merge 1 commit intoCMU-17313Q:mainfrom
mfahad2 wants to merge 1 commit intoCMU-17313Q:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactoring the function "getData" in the file src/controllers/recent.js so that the complexity could reduce
Changes Made:
To fix this issue the changes made included extracting the breadcrumbs & title into a new helper function. The logic of the RSS was also put into a helper function called "SetRssFields". An early return was added to simplify the validation.
Validation
To ensure that it was resolved I ran the qlty smell and the npm run lint and npm run test.
Resolves #17