Skip to content

Reduced complexity in the file src/user/create.js #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hangyiw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reduced complexity in the file src/user/create.js #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07e629d
Fix issue #36: lowering complexity of create() in src/user/create.js
hangyiw Sep 4, 2025
a821d89
Merge branch 'CMU-17313Q:main' into refactor-user-creation
hangyiw Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 39 additions & 21 deletions src/user/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,8 @@ module.exports = function (User) {
}
}

async function create(data) {
const timestamp = data.timestamp || Date.now();

let userData = {
async function createUserData(data, timestamp) {
const userData = {
username: data.username,
userslug: data.userslug,
joindate: timestamp,
Expand All @@ -61,23 +59,10 @@ module.exports = function (User) {
if (data.acceptTos === true) {
userData.acceptTos = 1;
}
return userData;
}

const renamedUsername = await User.uniqueUsername(userData);
const userNameChanged = !!renamedUsername;
if (userNameChanged) {
userData.username = renamedUsername;
userData.userslug = slugify(renamedUsername);
}

const results = await plugins.hooks.fire('filter:user.create', { user: userData, data: data });
userData = results.user;

const uid = await db.incrObjectField('global', 'nextUid');
const isFirstUser = uid === 1;
userData.uid = uid;

await db.setObject(`user:${uid}`, userData);

async function initializeUser(userData, timestamp, password) {
const bulkAdd = [
['username:uid', userData.uid, userData.username],
[`user:${userData.uid}:usernames`, timestamp, `${userData.username}:${timestamp}`],
Expand All @@ -99,25 +84,58 @@ module.exports = function (User) {
db.sortedSetAddBulk(bulkAdd),
groups.join(['registered-users', 'unverified-users'], userData.uid),
User.notifications.sendWelcomeNotification(userData.uid),
storePassword(userData.uid, data.password),
storePassword(userData.uid, password),
User.updateDigestSetting(userData.uid, meta.config.dailyDigestFreq),
]);
}

async function create(data) {
const timestamp = data.timestamp || Date.now();

// Create initial user data
let userData = await createUserData(data, timestamp);

// Handle username uniqueness
const renamedUsername = await User.uniqueUsername(userData);
const userNameChanged = !!renamedUsername;
if (userNameChanged) {
userData.username = renamedUsername;
userData.userslug = slugify(renamedUsername);
}

// Apply plugin filters
const results = await plugins.hooks.fire('filter:user.create', { user: userData, data: data });
userData = results.user;

// Generate UID and store user
const uid = await db.incrObjectField('global', 'nextUid');
const isFirstUser = uid === 1;
userData.uid = uid;
await db.setObject(`user:${uid}`, userData);

// Initialize user data structures
await initializeUser(userData, timestamp, data.password);

// Handle email confirmation
if (data.email && isFirstUser) {
await User.setUserField(uid, 'email', data.email);
await User.email.confirmByUid(userData.uid);
}

// Send validation email for regular users
if (data.email && userData.uid > 1) {
await User.email.sendValidationEmail(userData.uid, {
email: data.email,
template: 'welcome',
subject: `[[email:welcome-to, ${meta.config.title || meta.config.browserTitle || 'NodeBB'}]]`,
}).catch(err => winston.error(`[user.create] Validation email failed to send\n[emailer.send] ${err.stack}`));
}

// Handle username change notification
if (userNameChanged) {
await User.notifications.sendNameChangeNotification(userData.uid, userData.username);
}

plugins.hooks.fire('action:user.create', { user: userData, data: data });
return userData.uid;
}
Expand Down