Skip to content

Refactor public/src/admin/appearance/themes.js:init to reduce complexity #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhk2-cmu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor public/src/admin/appearance/themes.js:init to reduce complexity #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 61 additions & 48 deletions public/src/admin/appearance/themes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,74 +4,87 @@
define('admin/appearance/themes', ['bootbox', 'translator', 'alerts'], function (bootbox, translator, alerts) {
const Themes = {};

function getThemeInfoFrom(target) {
const parentEl = target.parents('[data-theme]');
return {
themeType: parentEl.attr('data-type'),
cssSrc: parentEl.attr('data-css'),
themeId: parentEl.attr('data-theme'),
};
}

function applyTheme(themeType, themeId, cssSrc) {
socket.emit('admin.themes.set', { type: themeType, id: themeId, src: cssSrc }, function (err) {
if (err) {
return alerts.error(err);
}
config['theme:id'] = themeId;
highlightSelectedTheme(themeId);

alerts.alert({
alert_id: 'admin:theme',
type: 'info',
title: '[[admin/appearance/themes:theme-changed]]',
message: '[[admin/appearance/themes:restart-to-activate]]',
timeout: 5000,
clickfn: function () {
require(['admin/modules/instance'], function (instance) {
instance.rebuildAndRestart();
});
},
});
});
}


Themes.init = function () {

$('#installed_themes').on('click', function (e) {
const target = $(e.target);
const action = target.attr('data-action');

if (action && action === 'use') {
const parentEl = target.parents('[data-theme]');
const themeType = parentEl.attr('data-type');
const cssSrc = parentEl.attr('data-css');
const themeId = parentEl.attr('data-theme');
// guarding clause to reduce nesting
if (action !== 'use') {
return;
}

const { themeType, cssSrc, themeId } = getThemeInfoFrom(target);

// already selected → no-op
if (config['theme:id'] === themeId) {
return;
}

applyTheme(themeType, themeId, cssSrc);
});

if (config['theme:id'] === themeId) {
$('#revert_theme').on('click', function () {
if (config['theme:id'] === 'nodebb-theme-harmony') {
return;
}
bootbox.confirm('[[admin/appearance/themes:revert-confirm]]', function (confirm) {
if (!confirm) {
return;
}
socket.emit('admin.themes.set', {
type: themeType,
id: themeId,
src: cssSrc,
type: 'local',
id: 'nodebb-theme-harmony',
}, function (err) {
if (err) {
return alerts.error(err);
}
config['theme:id'] = themeId;
highlightSelectedTheme(themeId);

config['theme:id'] = 'nodebb-theme-harmony';
highlightSelectedTheme('nodebb-theme-harmony');
alerts.alert({
alert_id: 'admin:theme',
type: 'info',
type: 'success',
title: '[[admin/appearance/themes:theme-changed]]',
message: '[[admin/appearance/themes:restart-to-activate]]',
timeout: 5000,
clickfn: function () {
require(['admin/modules/instance'], function (instance) {
instance.rebuildAndRestart();
});
},
message: '[[admin/appearance/themes:revert-success]]',
timeout: 3500,
});
});
}
});

$('#revert_theme').on('click', function () {
if (config['theme:id'] === 'nodebb-theme-harmony') {
return;
}
bootbox.confirm('[[admin/appearance/themes:revert-confirm]]', function (confirm) {
if (confirm) {
socket.emit('admin.themes.set', {
type: 'local',
id: 'nodebb-theme-harmony',
}, function (err) {
if (err) {
return alerts.error(err);
}
config['theme:id'] = 'nodebb-theme-harmony';
highlightSelectedTheme('nodebb-theme-harmony');
alerts.alert({
alert_id: 'admin:theme',
type: 'success',
title: '[[admin/appearance/themes:theme-changed]]',
message: '[[admin/appearance/themes:revert-success]]',
timeout: 3500,
});
});
}
});
});

socket.emit('admin.themes.getInstalled', function (err, themes) {
if (err) {
return alerts.error(err);
Expand Down