Conversation
Review Summary by Qodoleading 값 수정 및 메타데이터 베이스 URL 설정
WalkthroughsDescription• leading 값을 leading-2에서 leading-[160%]로 수정 • OG 이미지 메타데이터 지원을 위해 metadataBase 추가 • 두 개 컴포넌트에서 일관된 line-height 적용 Diagramflowchart LR
A["Leading 스타일 수정"] --> B["leading-2 → leading-[160%]"]
C["메타데이터 설정"] --> D["metadataBase URL 추가"]
B --> E["StartExtraInfo.tsx"]
B --> F["StartOnBoarding.tsx"]
D --> G["layout.tsx"]
File Changes1. app/extra-info/_components/StartExtraInfo.tsx
|
Enabling\disabling automation
meaning the
the tool will replace every marker of the form
Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all. |
Custom labelsThe default labels of the If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. |
Inline File Walkthrough 💎For enhanced user experience, the To enable inline file summary, set
|
Utilizing extra instructionsThe Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. |
More PR-Agent commands
|
See the describe usage page for a comprehensive guide on using this tool.
Code Review by Qodo
1. Wrong metadataBase domain
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 사용자 인터페이스의 텍스트 가독성을 향상시키고 소셜 미디어 공유 시 웹사이트 정보가 더 잘 표시되도록 하는 것을 목표로 합니다. 특정 컴포넌트의 텍스트 줄 간격을 조정하고, Open Graph 메타데이터의 기본 URL을 설정하여 외부 플랫폼에서 콘텐츠가 풍부하게 미리보기 될 수 있도록 준비했습니다. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
안녕하세요. 이번 PR에서 leading 스타일을 수정하여 가독성을 개선하고, OG 이미지 공유를 위해 metadataBase를 추가하신 것을 확인했습니다. leading 값 수정은 적절한 변경으로 보입니다. app/layout.tsx에 추가된 metadataBase의 경우, 현재 URL이 하드코딩되어 있어 유지보수성을 높이기 위한 개선 제안을 드렸습니다. 환경 변수를 사용하면 여러 배포 환경에서 더 유연하게 대처할 수 있을 것입니다. 자세한 내용은 코드 리뷰 코멘트를 참고해 주세요.
| }); | ||
|
|
||
| export const metadata: Metadata = { | ||
| metadataBase: new URL("https://comatching.com"), // 실제 도메인 주소로 변경 필요 |
There was a problem hiding this comment.
metadataBase에 URL을 하드코딩하는 대신 환경 변수를 사용하는 것을 권장합니다. 코드에 남겨주신 주석(// 실제 도메인 주소로 변경 필요)을 고려할 때, 환경별로 다른 도메인을 설정해야 할 수 있습니다. 환경 변수를 사용하면 개발, 스테이징, 프로덕션 환경에 따라 유연하게 URL을 관리할 수 있어 유지보수성이 향상됩니다.
예를 들어, process.env.NEXT_PUBLIC_SITE_URL을 사용하고, 설정되지 않았을 경우를 대비해 기본값을 제공하는 방식이 좋습니다.
| metadataBase: new URL("https://comatching.com"), // 실제 도메인 주소로 변경 필요 | |
| metadataBase: new URL(process.env.NEXT_PUBLIC_SITE_URL || "https://comatching.com"), // 실제 도메인 주소로 변경 필요 |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| }); | ||
|
|
||
| export const metadata: Metadata = { | ||
| metadataBase: new URL("https://comatching.com"), // 실제 도메인 주소로 변경 필요 |
There was a problem hiding this comment.
1. Wrong metadatabase domain 🐞 Bug ✓ Correctness
app/layout.tsx hardcodes metadataBase to https://comatching.com, so relative OpenGraph/Twitter image URLs like /og-image.png resolve to the wrong host when the app is served from comatching.site. This breaks link previews/canonical URL resolution for the actual deployment domain referenced elsewhere in the codebase.
Agent Prompt
### Issue description
`metadataBase` is hardcoded to `https://comatching.com`, but the app uses relative OG/Twitter image URLs and the codebase references `https://comatching.site` as the expected frontend domain. This causes OG/Twitter tags to point at the wrong host.
### Issue Context
Next.js resolves relative metadata URLs (like `/og-image.png`) against `metadataBase`. If the deployment host differs (prod/staging/preview), hardcoding the base will break link previews.
### Fix Focus Areas
- app/layout.tsx[17-45]
- lib/actions/loginAction.ts[73-81]
### Implementation notes
- Introduce an env var such as `NEXT_PUBLIC_SITE_URL` (or `SITE_URL`) and set it per environment.
- Set `metadataBase: new URL(process.env.NEXT_PUBLIC_SITE_URL ?? "http://localhost:3000")` (or equivalent server-only env) and ensure the value matches the actual deployed frontend domain.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
1 participant
No description provided.