Skip to content

Conversation

YooSunYoung
Copy link
Contributor

doubleHiggsAnalyser lines are commented out in BuildFile.xml since it can't be built before all the libraries are installed.

<flags CXXFLAGS="-g" />
</bin>

<!--erase this line after executing lines in nano/analysis/test/hh/external_library_recipe.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why erase line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because external libraries should be installed to build the analyser but not everybody needs to install them
should I remove include lines in the analyser instead...?

@@ -0,0 +1,29 @@
cd $CMSSW_BASE/src/nano/
wget http://www.hep.phy.cam.ac.uk/~lester/dtm662/mt2/Releases/oxbridgekinetics.tar.gz
tar -xzvf oxbridgekinetics.tar.gz
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if only a few files are needed, just add it to the external lib

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't exactly know what I should use among them for now

<flags CXXFLAGS="-Wno-error=unused-variable" />
<flags CXXFLAGS="-Wno-error=sign-compare" />
<flags CXXFLAGS="-Wno-error=maybe-uninitialized" />
<export>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha i dont like these error ignores

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ian has put them though.. should I remove them?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, you'd have to rewrite the external packages to not throw them. I figured it was easier to just ignore... If we put the packages in external I guess we can have them there only and not for our code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ian has put them though.. should I remove them?

You can try to remove them. From memory it was the oxbridge packages that cause it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, i dont mind the unused variables, but i think the other two should be fixed in their code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants