-
Notifications
You must be signed in to change notification settings - Fork 12
[Double Higgs] analyser, script for installing the libraries and tmva training script #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…d tmva bdt/bdtg training script
<flags CXXFLAGS="-g" /> | ||
</bin> | ||
|
||
<!--erase this line after executing lines in nano/analysis/test/hh/external_library_recipe.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why erase line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because external libraries should be installed to build the analyser but not everybody needs to install them
should I remove include lines in the analyser instead...?
@@ -0,0 +1,29 @@ | |||
cd $CMSSW_BASE/src/nano/ | |||
wget http://www.hep.phy.cam.ac.uk/~lester/dtm662/mt2/Releases/oxbridgekinetics.tar.gz | |||
tar -xzvf oxbridgekinetics.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if only a few files are needed, just add it to the external lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't exactly know what I should use among them for now
<flags CXXFLAGS="-Wno-error=unused-variable" /> | ||
<flags CXXFLAGS="-Wno-error=sign-compare" /> | ||
<flags CXXFLAGS="-Wno-error=maybe-uninitialized" /> | ||
<export> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha i dont like these error ignores
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ian has put them though.. should I remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, you'd have to rewrite the external packages to not throw them. I figured it was easier to just ignore... If we put the packages in external I guess we can have them there only and not for our code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ian has put them though.. should I remove them?
You can try to remove them. From memory it was the oxbridge packages that cause it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, i dont mind the unused variables, but i think the other two should be fixed in their code
doubleHiggsAnalyser lines are commented out in BuildFile.xml since it can't be built before all the libraries are installed.