feat: move video presets to input_node config#173
Draft
codeflight1 wants to merge 1 commit into
Draft
Conversation
Member
|
Overall not a huge fan of this architecture. I believe the client should be allowed to set any configuration it wants without it necessarily being saved. IMO this node is already handling more than it's fair share of logic and this further grows it into a untracable mess of spaghetti code. Parameters should not be used as state tracking. My thoughts would be to either: seperate the preset handler into it's own class or just maintain a list of presets that can be read by clients with the client then using them as it see's fit. During testing I also found it very unreliable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves video presets to the
input_nodeconfig for a single source of truth between webUI and joystick carousell controls. Draft until I test on-rover.