Skip to content

feat: move video presets to input_node config#173

Draft
codeflight1 wants to merge 1 commit into
mainfrom
feat-video-sources
Draft

feat: move video presets to input_node config#173
codeflight1 wants to merge 1 commit into
mainfrom
feat-video-sources

Conversation

@codeflight1

Copy link
Copy Markdown
Contributor

Moves video presets to the input_node config for a single source of truth between webUI and joystick carousell controls. Draft until I test on-rover.

@ConnorNeed

ConnorNeed commented Jul 19, 2026

Copy link
Copy Markdown
Member

Overall not a huge fan of this architecture. I believe the client should be allowed to set any configuration it wants without it necessarily being saved. IMO this node is already handling more than it's fair share of logic and this further grows it into a untracable mess of spaghetti code. Parameters should not be used as state tracking.

My thoughts would be to either: seperate the preset handler into it's own class or just maintain a list of presets that can be read by clients with the client then using them as it see's fit.

During testing I also found it very unreliable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants