-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rewrite for inlining a single Call #1934
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
7a3ac0b
Add InlineCall - v0 supporting recursion but no other incoming edges
acl-cqc 6d8dfc1
fix verify to also check call target
acl-cqc 0d5b5af
Update portgraph to 0.13.2
acl-cqc 75f8842
Add HugrMut::copy_subtree. TODO check for invalidation?
acl-cqc 4c345eb
InlineCall uses copy_subtree
acl-cqc 120f17c
First test; fix copying of optypes,metadata,hierarchy
acl-cqc c10c81a
WIP test
acl-cqc 45dc680
Fix recursion by changing copy_subtree => copy_descendants
acl-cqc d3f9c62
Validate in test
acl-cqc 231b125
Tidy tests w/helper methods calls/extension_ops
acl-cqc 756902a
refactor test: inline get_nonrec_call
acl-cqc 8db58de
Fix tests for --all-features
acl-cqc 45dd9ac
Update that comment
acl-cqc c995322
test errors, improve+derive InlineCallError
acl-cqc 5a1f2f8
Use hierarchy.descendants
acl-cqc 7f86624
oops, fix prev
acl-cqc b32065b
Add InlineCall::new
doug-q f7069c0
Add Option<Substitution> to copy_descendants
acl-cqc feaaace
Merge remote-tracking branch 'origin/main' into HEAD
acl-cqc 49a5726
comment => doc comment
acl-cqc 787773a
doc new
acl-cqc ee38b5b
use derive_more not thiserror
acl-cqc 8e4bf5d
Use RootChecked to improve coverage
acl-cqc 7f13f41
Use BTreeMap, changing translate_indices to return impl Iterator
acl-cqc 122c751
Test nesting
acl-cqc 99a152a
Add static edge, check it gets preserved (it doesn't)
acl-cqc 5f47685
Preserve Order edges
acl-cqc eb95372
Add test of polymorphism
acl-cqc 1a71d61
Fix by updating portgraph
acl-cqc acefcda
Merge remote-tracking branch 'origin/main' into acl/inline_call
acl-cqc 1caa970
Fix --all-features test
acl-cqc 0f78db5
common up a get_optype
acl-cqc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like the hierarchy part isn't covered, do you need a test with more nesting?