LowerTypes: provide handlers for linearizing arrays #2023
+878
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
…2018) * Does not handle nonlocal edges. This is much more involved, not part of this PR. I note #1912 * handlers for arrays follow in #2023 BREAKING CHANGE: `OpReplacement` renamed to `NodeTemplate`. Note this is *not* a breaking change if this PR goes in the same release as #1989 (which introduced `OpReplacement`) --------- Co-authored-by: Douglas Wilson <[email protected]>
|
Hey there and thank you for opening this pull request! 👋 We require pull request titles to follow the Conventional Commits specification Your title should look like this. The scope field is optional. If the PR includes a breaking change, mark it with an exclamation mark: and include a "BREAKING CHANGE:" footer in the body of the pull request. Details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #2018.
Question: what do we do with these handlers? ATM I've just made them public and left 'em...
Add
LowerTypes::with_array_handlers? They are needed only if you are turning some other Copyable type into a linear one...Include them in LowerTypes::default? You can override them if you really don't want them...