-
Notifications
You must be signed in to change notification settings - Fork 13
feat!: Remove RootCheckable
#2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2704 +/- ##
=======================================
Coverage 83.53% 83.54%
=======================================
Files 266 266
Lines 51718 51714 -4
Branches 47184 47180 -4
=======================================
Hits 43202 43202
+ Misses 6136 6134 -2
+ Partials 2380 2378 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ss2165
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally the try_new(..).unwrap() would be .expect("dfg root") etc.
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
Closes #2577 .
BREAKING CHANGE: Use
RootCheckedorHugrViewinstead ofRootCheckable.