-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new end-to-end parser class #227
Conversation
Let's decide a name for this parser and rename everything appropriately. |
@neiljdo We will also need to make this work with DisCoCircReader which takes a CCGParser now. We can do it in this or in a follow-up PR. |
@neiljdo Based on the discussions, I think it makes sense to proceed with the following after all:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, let's merge it and open follow-up PRs for the rest. First thing would be to make it work with DisCoCirc I guess.
This PR implements a new parser class that skips CCGTree derivations when creating pregroup diagrams.