Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mermaid render of graph views was empty #175

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

aborgna-q
Copy link
Collaborator

Fixes #174

@aborgna-q aborgna-q requested a review from lmondada January 20, 2025 15:44
@aborgna-q aborgna-q force-pushed the ab/fix-region-render branch from a621935 to 7a31136 Compare January 20, 2025 15:49
@aborgna-q aborgna-q force-pushed the ab/fix-region-render branch from 7a31136 to a87a795 Compare January 20, 2025 15:53
@aborgna-q aborgna-q enabled auto-merge January 20, 2025 15:53
@aborgna-q aborgna-q added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit fbd65b7 Jan 20, 2025
10 checks passed
@aborgna-q aborgna-q deleted the ab/fix-region-render branch January 20, 2025 15:55
@hugrbot hugrbot mentioned this pull request Jan 20, 2025
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.27%. Comparing base (8f46ae0) to head (a87a795).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #175      +/-   ##
==========================================
+ Coverage   83.23%   83.27%   +0.03%     
==========================================
  Files          24       24              
  Lines        6091     6104      +13     
  Branches     6091     6104      +13     
==========================================
+ Hits         5070     5083      +13     
  Misses        945      945              
  Partials       76       76              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-merge-queue bot pushed a commit that referenced this pull request Jan 20, 2025
## 🤖 New release
* `portgraph`: 0.13.0 -> 0.13.1 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.13.1](v0.13.0...v0.13.1)
- 2025-01-20

### Bug Fixes

- Mermaid render of graph views was empty (#175)
- Hierarchy descendants return root siblings (#178)
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
@hugrbot hugrbot mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Region graph views cannot be rendered as mermaid graphs.
2 participants