-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: RFC: remove helpers (post-RPITIT TLC) #181
base: main
Are you sure you want to change the base?
Conversation
fn all_neighbours(&self, node: NodeIndex) -> impl Iterator<Item = NodeIndex> + Clone; | ||
} | ||
fn get_connections( | ||
&self, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line count would look significantly better if the old, delegate!
, versions of these didn't exceed the line length limit !!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## acl/port_links #181 +/- ##
==================================================
- Coverage 83.54% 83.49% -0.06%
==================================================
Files 24 24
Lines 6315 6320 +5
Branches 6315 6320 +5
==================================================
+ Hits 5276 5277 +1
- Misses 967 969 +2
- Partials 72 74 +2 ☔ View full report in Codecov by Sentry. |
c3fa811
to
30f998e
Compare
CodSpeed Performance ReportMerging #181 will not alter performanceComparing Summary
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
We don't really need the various helpers typed as returning
NodeConnections
etc. now, but removing them is a bit of a PITA because some of these structs contain each other (hence, must be parametrized) - so I haven't done all of them, thought I'd RFC first...Note: rebased to come after #188