feat: force-order qfree early and qalloc late. #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-q
commented
Feb 5, 2025
tket2-hseries/src/lib.rs
Outdated
| let is_read = optype.cast() == Some(FutureOpDef::Read); | ||
|
|
||
| // HACK: for now qallocs and qfrees are not adequately ordered, | ||
| // see TODO. To mitigate this we push qfrees as early as possible |
There was a problem hiding this comment.
What issue should we point to here?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
- Coverage 82.31% 82.09% -0.23%
==========================================
Files 63 63
Lines 7742 7763 +21
Branches 7486 7507 +21
==========================================
Hits 6373 6373
- Misses 979 1000 +21
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
cqc-alec
approved these changes
Feb 5, 2025
Done #765 |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
## 🤖 New release * `tket2`: 0.7.1 -> 0.7.2 (✓ API compatible changes) * `tket2-hseries`: 0.8.0 -> 0.9.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.7.1](tket2-v0.7.0...tket2-v0.7.1) - 2025-01-10 ### Bug Fixes - remove unicode pi symbols in rotation extension (#743) </blockquote> ## `tket2-hseries` <blockquote> ## [0.9.0](tket2-hseries-v0.8.0...tket2-hseries-v0.9.0) - 2025-02-12 ### Bug Fixes - Use `RemoveDeadFuncsPass` instead of deprecated `remove_polyfuncs()` (#759) - nondeterminism in lazify-measure (#766) ### New Features - *(tket2-hseries)* Add `tket2.wasm` extension (#737) - force-order qfree early and qalloc late. (#762) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #761