Apply Extensions from transaction log #299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation build overview
Show files changed (3 files in total): 📝 2 modified | ➕ 1 added | ➖ 0 deleted
|
gregbell26
requested review from
gregbell26
and removed request for
ezrichards
gregbell26
changed the title
… an extension as applied or ignored
gregbell26
reviewed
Sep 15, 2025
packtrain-service/src/main/java/edu/mines/packtrain/services/ExtensionService.java
Show resolved
Hide resolved
gregbell26
reviewed
Sep 15, 2025
packtrain-service/src/main/java/edu/mines/packtrain/services/ExtensionService.java
Outdated
Show resolved
Hide resolved
gregbell26
reviewed
Sep 18, 2025
| private LateRequestStatus extensionStatus; | ||
| private String extensionMessage; | ||
| private String submissionMessage; | ||
| private int numberExtensionDaysApplied; |
There was a problem hiding this comment.
We need to make a policy server update to that this field actually gets applied.
We also need to update the docs for this
…ktrain into jettzoeyExtensionApplication
gregbell26
requested changes
Sep 22, 2025
packtrain-service/src/test/java/edu/mines/packtrain/services/TestExtensionService.java
Outdated
Show resolved
Hide resolved
packtrain-service/src/test/java/edu/mines/packtrain/services/TestExtensionService.java
Outdated
Show resolved
Hide resolved
packtrain-service/src/test/java/edu/mines/packtrain/services/TestExtensionService.java
Outdated
Show resolved
Hide resolved
packtrain-service/src/main/java/edu/mines/packtrain/services/ExtensionService.java
Outdated
Show resolved
Hide resolved
Comment on lines
+20
to
+24
| @Query("select l from migration_transaction_log l where l.migrationId = ?1 " + | ||
| "and l.revision = (select max(l2.revision) from migration_transaction_log l2 where l2.cwid = l.cwid )") | ||
| // grabbing the latest revision from migration transaction log by migration id | ||
| // cursed subquery version (im so sorry) | ||
| List<MigrationTransactionLog> getLatestByMigrationId(UUID migrationId); |
There was a problem hiding this comment.
Do we have any tests covering this?
There was a problem hiding this comment.
add stuff to the repo, use process function from migration service one to grab out and make sure we are getting back what we need, all of this goes into the same test
…ktrain into jettzoeyExtensionApplication
…ktrain into jettzoeyExtensionApplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.