Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PDF download functionality and update tests #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add PDF download functionality and update tests #37

wants to merge 3 commits into from

Conversation

FLASH2332
Copy link
Contributor

  • Added DownloadFile function to WebClient for downloading PDFs.
  • Updated MockWebClient to support DownloadFile in tests.
    I am not sure if the unit tests cover and check this functionality fully
    Solves Enhance CLI Tool with a PDF Download Option #36 if it can be considered a useful change

@Ashrockzzz2003 Ashrockzzz2003 linked an issue Mar 1, 2025 that may be closed by this pull request
Enhance CLI Tool with a PDF Download Option #36
Open
@Ashrockzzz2003 Ashrockzzz2003 self-requested a review March 1, 2025 18:21
Ashrockzzz2003
Ashrockzzz2003 requested changes Mar 1, 2025
View reviewed changes
Copy link
Member

@Ashrockzzz2003 Ashrockzzz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an useful feature. We can refine this a bit more i believe. But first, fix the warnings from CI and make it pass. We'll continue from there!

@Ashrockzzz2003
Copy link
Member

/bounty 40 @FLASH2332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashrockzzz2003 Ashrockzzz2003 Ashrockzzz2003 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@FLASH2332 FLASH2332

Labels
AMWOC AMWOC-accepted
Projects
amrita_pyq
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance CLI Tool with a PDF Download Option
2 participants
@FLASH2332 @Ashrockzzz2003