-
Notifications
You must be signed in to change notification settings - Fork 4
Add NeoForge support #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds initial NeoForge support to the project, extending mod compatibility and integrating with NeoForge APIs.
- Introduces a new Maven repository and toolchain configuration in settings.gradle.
- Adds new mod metadata, logging, event, command, and executor classes specific to NeoForge.
- Updates Gradle build scripts and CI workflows to include the new "neoforge" target.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
settings.gradle | Adds NeoForge Maven repository, toolchain plugin, and includes the neoforge project. |
neoforge/src/main/templates/META-INF/neoforge.mods.toml | Provides module metadata template for NeoForge mods. |
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/logger/ForgeLogger.java | Implements a logger for the NeoForge platform by extending the common abstract logger. |
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/listener/ForgeEventAdapter.java | Maps platform-specific events from NeoForge to the common event bus. |
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/executor/ForgeServerExecutor.java | Provides an executor implementation to schedule tasks synchronously on the server. |
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/command/ForgeCommandService.java | Registers commands using brigadier for NeoForge. |
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/adapter/ForgeServerChatAdapter.java | Bridges server chat events by converting messaging components between formats. |
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/NeoForgeCSSMinecraftPlugin.java | Main plugin class that sets up the NeoForge adapter, executor, and command service. |
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/CSSMinecraftLoader.java | Loader that initializes and registers the plugin with NeoForge’s event bus. |
neoforge/gradle.properties | Contains configuration and version properties for the mod. |
neoforge/build.gradle | Configures dependencies, tasks, and run configurations for building the NeoForge mod. |
.github/workflows/build.yml | Updates the CI workflow to include the new "neoforge" build target. |
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/command/ForgeCommandService.java
Show resolved
Hide resolved
neoforge/src/main/java/com/cssbham/cssminecraft/neoforge/NeoForgeCSSMinecraftPlugin.java
Show resolved
Hide resolved
LMBishop
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds NeoForge support for 1.21.1.
The compiled jar file ends up too large - still needs fixing and general cleanup may be needed prior to merging.